-
Notifications
You must be signed in to change notification settings - Fork 186
feat(Quote): Quote wrapper pattern uses new grid; build quote block #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8ab4862 to
86e97c4
Compare
43e0892 to
bebae88
Compare
|
Thanks @jmuzina , Looks nice!
Thanks again! |
Thanks for pointing this out, I've adjusted accordingly: Screencast.from.2025-11-20.09-55-44.webm
@kim-isaac This PR doesn't add support for quote wrappers with multiple quote blocks, as that would change the API of the pattern. I'd suggest this can be done in a follow-up. In the current PR, the quote wrapper will never have muted rules, because there is only ever one block. However, I have prepared the pattern to support multiple blocks by exposing a |
|
@jmuzina Thank you for the update! My concern about the second part is that, if two or more quotes appear within a single section, they may all be treated as the first block and come without the rule for all of them (live site example) If that’s the case, then until we support multiple quote blocks within the pattern, I think we should keep the rule visible even on the first block. |
92afa55 to
42da9de
Compare
I'd like to clarify which rules we're talking about here. This pattern currently has two HRs:
Since this pattern's initial implementation, that top (default) rule has only been shown if a title is present. This remains the case now. I've taken advantage of this for the time being by only showing the muted rule if no title row is present, which seems to be the case for users who are rendering quote patterns one after another, as you linked. The result is that we can remove the muted rule from quotes with title rows (these are always the first block as far as I understand) and keep it for quotes without title rows. Here's an example. Does this work? If so, quote wrapper could benefit from the new approach to rules early (refactoring it to use two blocks will be much more effort). Alternatively, I can always render the muted rule. |
|
@jmuzina Thanks for the explanation! |
42da9de to
02c4dc0
Compare
e3499c8 to
bc7f0a8
Compare
bc7f0a8 to
e451c3c
Compare
e451c3c to
c77164a
Compare
Done
Fixes #5589
Fixes WD-23969
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention