Skip to content

Conversation

@jmuzina
Copy link
Member

@jmuzina jmuzina commented Nov 17, 2025

Done

  • Enables embedding the pattern in future patterns
    • Updates the quote wrapper pattern to use the new 4/4/8 grid.
    • Refactors the quote wrapper pattern to use blocks. These blocks could be consumed by other patterns in the future.
    • Simplifies the use of separators (p-rule) inside the quote wrapper (see thread)
      • Top rule is a default rule, instead of a highlighted rule.
      • Removed muted rules within the quote block. Muted rules will only be used to separate quote blocks from each other when the pattern supports multiple quotes.
    • Removed the shallow section spacing around quote text (it is no longer present in the design)

Fixes #5589
Fixes WD-23969

QA

  • Use quote examples and Percy to compare the examples against the design.
    • Please be sure to check on all 3 breakpoints and carefully look at all examples in the example set. Pay special attention to the use of horizontal rules, spacing beneath quote text, and grid column distribution of signpost column & quote body.
    • To see the grid distribution change, compare before and after on the medium breakpoint.
  • Open quote block examples and match it against the design.
  • Review release notes

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

@jmuzina jmuzina added Review: Design needed Review: QA needed Review: Code needed Question ❓ Further information is requested Blocked ⛔ Review: Percy needed This PR needs a review of Percy for visual regressions labels Nov 17, 2025
@webteam-app
Copy link

@jmuzina jmuzina requested a review from kim-isaac November 17, 2025 20:20
@jmuzina jmuzina force-pushed the quote-wrapper-new-grid branch from 8ab4862 to 86e97c4 Compare November 18, 2025 18:45
@jmuzina jmuzina marked this pull request as ready for review November 18, 2025 18:52
@jmuzina jmuzina added Feature 🎁 New feature or request and removed Question ❓ Further information is requested Blocked ⛔ labels Nov 18, 2025
@jmuzina jmuzina force-pushed the quote-wrapper-new-grid branch from 43e0892 to bebae88 Compare November 18, 2025 18:54
@jmuzina jmuzina added Maintenance 🔨 and removed Feature 🎁 New feature or request labels Nov 18, 2025
@kim-isaac
Copy link

kim-isaac commented Nov 19, 2025

Thanks @jmuzina , Looks nice!
I have two comments below:

  • At the medium dimension, the title and link should each expand to 100% width and stack vertically. (please check the figma file)
  • Could I we have an example screens showing 2 or more blocks together? I'd like to verify whether the muted rule appears between them

Thanks again!

@jmuzina
Copy link
Member Author

jmuzina commented Nov 20, 2025

At the medium dimension, the title and link should each expand to 100% width and stack vertically. (please check the figma file)

Thanks for pointing this out, I've adjusted accordingly:

Screencast.from.2025-11-20.09-55-44.webm

Could I we have an example screens showing 2 or more blocks together? I'd like to verify whether the muted rule appears between them

@kim-isaac This PR doesn't add support for quote wrappers with multiple quote blocks, as that would change the API of the pattern. I'd suggest this can be done in a follow-up. In the current PR, the quote wrapper will never have muted rules, because there is only ever one block. However, I have prepared the pattern to support multiple blocks by exposing a has_divider setting at the block level, which the quote wrapper pattern could set to True for quote blocks after the first one.

https://github.com/jmuzina/vanilla-framework/blob/bebae8899eec8a2823095e396a6584874f59e8ea/templates/_macros/vf_quote-wrapper.jinja#L284-L285

@kim-isaac
Copy link

@jmuzina Thank you for the update!

My concern about the second part is that, if two or more quotes appear within a single section, they may all be treated as the first block and come without the rule for all of them (live site example)

If that’s the case, then until we support multiple quote blocks within the pattern, I think we should keep the rule visible even on the first block.

@jmuzina jmuzina force-pushed the quote-wrapper-new-grid branch from 92afa55 to 42da9de Compare November 20, 2025 23:57
@jmuzina
Copy link
Member Author

jmuzina commented Nov 21, 2025

@kim-isaac

My concern about the second part is that, if two or more quotes appear within a single section, they may all be treated as the first block and come without the rule for all of them (live site example)

If that’s the case, then until we support multiple quote blocks within the pattern, I think we should keep the rule visible even on the first block.

I'd like to clarify which rules we're talking about here. This pattern currently has two HRs:

  • default rule(formerly highlighted) at the top of the pattern above the title, spanning the grid
  • muted rule above quote text, spanning the second 75%. Should only be shown on non-first blocks.

Since this pattern's initial implementation, that top (default) rule has only been shown if a title is present. This remains the case now.

I've taken advantage of this for the time being by only showing the muted rule if no title row is present, which seems to be the case for users who are rendering quote patterns one after another, as you linked. The result is that we can remove the muted rule from quotes with title rows (these are always the first block as far as I understand) and keep it for quotes without title rows. Here's an example. Does this work? If so, quote wrapper could benefit from the new approach to rules early (refactoring it to use two blocks will be much more effort).

Alternatively, I can always render the muted rule.

@kim-isaac
Copy link

@jmuzina Thanks for the explanation!
Given the structure you described, it sounds like updating the pattern won’t cause any issues on the live pages. That’s reassuring :) I'll add +1 with the current structure you've shared!

@jmuzina jmuzina force-pushed the quote-wrapper-new-grid branch 2 times, most recently from e3499c8 to bc7f0a8 Compare December 4, 2025 03:57
@jmuzina jmuzina mentioned this pull request Dec 4, 2025
6 tasks
@jmuzina jmuzina force-pushed the quote-wrapper-new-grid branch from bc7f0a8 to e451c3c Compare December 5, 2025 18:09
@jmuzina jmuzina force-pushed the quote-wrapper-new-grid branch from e451c3c to c77164a Compare December 18, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update quote wrapper pattern to use 4/4/8 grid

3 participants