Skip to content

Conversation

@tanujbhaud
Copy link

@tanujbhaud tanujbhaud commented Dec 23, 2025

Done

  • Added quotes: none to the .p-pull-quote mixin to prevent browser default quotes from appearing when the pattern is applied to a <blockquote> element.
  • Explicitly reset ::before and ::after content on the pull quote container to none to avoid overlapping pseudo-elements in environments with global blockquote styles.

Fixes #5711

QA

  • Open Pull quote variants example
  • To simulate the bug in the browser console/dev tools, apply the following styles to any pull quote blockquote element:
    blockquote { quotes: "“" "”"; }
    blockquote::before { content: open-quote; color: red; }
  • Verify that with the fix, the red quotes do not appear.

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨. (This is a Bug 🐛)
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

Original bug screenshots can be found in the issue #5711.
Before:
screenshot_before

After:
screenshot_after

Calendar and clock icons in date/time inputs were difficult to see
in dark mode. Applied filter: invert(1) to webkit-calendar-picker-indicator
pseudo-elements when inside .is-dark containers.

Fixes canonical#5696
Added quotes: none and reset ::before/::after on pull quote containers
to prevent browser default blockquote styles from adding extra quotes.
@webteam-app
Copy link

tanujbhaud is not a collaborator of the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pull quote has displays issues with additional double quotes

2 participants