Open
Conversation
Contributor
Author
|
Do not merge until all tests are passing: The root cause of the "random" packet size limit errors. Is caused by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
@cap-js/hanawill always callpreparefor queries that have placeholders?. With this PR theSQLstatement is used as a cache key preventingpreparefrom being called. Allowing already prepared statements to be run directly. Reducing the amount of round trips. It is not allowed to runSELECTstatements instatement.runBatch. Therefor it is not possible to use the event loop as an arguments collection mechanism to further reduce network overhead. As the HANA connection is (currently) only capable of having a single packed in flight there is no possibility that performance will be worsened by having statement executions be queued on the cached prepared statement.There is a special case for streaming queries (incl. blob streams for
@sap/hana-client). It is not possible to determine when the preparedstatementis no longer required. Therefor the prepared statements for streaming queries are detached from the cache once initiated.