Support for a custom mode w/template string replacement#24
Open
carlmathisen wants to merge 2 commits intocapaj:masterfrom
Open
Support for a custom mode w/template string replacement#24carlmathisen wants to merge 2 commits intocapaj:masterfrom
carlmathisen wants to merge 2 commits intocapaj:masterfrom
Conversation
Collaborator
|
Thanks, that seems like a very useful addition indeed! I'm very eager to merge this into develop, however I'd be even more indulgent if you could add some tests to back your new feature. Could you add some examples of how you use this feature (example input and output) and if possible some edge cases in which this could go wrong? I can then put those in some testcases and add the feature :) |
Owner
|
@carlmathisen thanks for opening this PR, but like @call-a3 we need those tests before we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi capaj,
I wanted a simple reusable way of modifying the expand command by creating a custom mode. This way i can just pass a template parameter into require
outputs e.g:
Let me know if the principle is of interest.