Skip to content

Hide progress bar when images finished loading #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
captainepoch merged 1 commit into from
Sep 27, 2025
Merged

Hide progress bar when images finished loading #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions husky/app/src/main/java/com/keylesspalace/tusky/fragment/ViewImageFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ class ViewImageFragment : ViewMediaFragment() {
}

override fun onToolbarVisibilityChange(visible: Boolean) {
if (binding.photoView == null || !userVisibleHint || binding.captionSheet == null) {
if (!userVisibleHint) {
return
}
isDescriptionVisible = showingDescription && visible
Expand Down Expand Up @@ -332,7 +332,10 @@ class ViewImageFragment : ViewMediaFragment() {
// so in case of cache miss, onStart is used
}

override fun onFinish() {}
override fun onFinish() {
binding.progressBar.hide()
}

override fun onProgress(progress: Int) {
// TODO: make use of it :)
}
Expand Down