Implement RBF and CPFP with new fees package and add pending transactions view in @caravan/coordinator by Legend101Zz · Pull Request #116 · caravan-bitcoin/caravan

Legend101Zz · 2024-08-06T22:55:34Z

This commit lays foundation of introduction of significant enhancements to be done to the transaction management capabilities of caravan/coordinator, focusing on Replace-By-Fee (RBF) and Child-Pays-For-Parent (CPFP) functionalities, along with a new pending transactions view.

Key changes Expected:

Pending Transactions View:
- Add new component 'PendingTransactionsView' in src/components/Wallet/
- Implement basic layout showing transaction ID, amount, recipient, and timestamp
- Integrate view into main Wallet dashboard
Enhanced Transaction Information:
- Add 'TransactionDetails' component to display comprehensive tx info
- Implement time-pending calculation and display
- Add current fee rate vs market rate comparison
- Include estimated blocks until confirmation based on current mempool state
Fee Bumping Possibility Indicators:
- Add RBF status indicator to transaction details
- Implement change output detection and display
- Calculate and show estimated cost for potential fee bump
UI Support for Manual RBF:
- Modify existing transaction creation flow to support RBF
- Add RBF toggle in transaction creation form (OutputsForm.jsx)
- Implement logic to replace existing transaction when RBF is selected
Fee Bumping Interfaces:
- Add 'CancelTransaction' button and associated logic
- Implement 'AccelerateTransaction' functionality
- Create 'DownloadPSBT' option for RBF/CPFP transactions
- Modify transaction authoring page to support pre-filled RBF/CPFP data
Integration with new fees package:
- Import and utilize functions from @caravan/fees for fee calculations
- Implement FeeManager class to handle fee-related operations
State Management Updates:
- Add new reducers for managing pending transactions and fee bump operations
- Implement new actions for RBF and CPFP operations
- Update selectors to support new state structure

…ions view in @caravan/coordinator This commit introduces significant enhancements to the transaction management capabilities of caravan/coordinator, focusing on Replace-By-Fee (RBF) and Child-Pays-For-Parent (CPFP) functionalities, along with a new pending transactions view. Key changes Expected: 1. Pending Transactions View: - Add new component 'PendingTransactionsView' in src/components/Wallet/ - Implement basic layout showing transaction ID, amount, recipient, and timestamp - Integrate view into main Wallet dashboard 2. Enhanced Transaction Information: - Add 'TransactionDetails' component to display comprehensive tx info - Implement time-pending calculation and display - Add current fee rate vs market rate comparison - Include estimated blocks until confirmation based on current mempool state 3. Fee Bumping Possibility Indicators: - Add RBF status indicator to transaction details - Implement change output detection and display - Calculate and show estimated cost for potential fee bump 4. UI Support for Manual RBF: - Modify existing transaction creation flow to support RBF - Add RBF toggle in transaction creation form (OutputsForm.jsx) - Implement logic to replace existing transaction when RBF is selected 5. Fee Bumping Interfaces: - Add 'CancelTransaction' button and associated logic - Implement 'AccelerateTransaction' functionality - Create 'DownloadPSBT' option for RBF/CPFP transactions - Modify transaction authoring page to support pre-filled RBF/CPFP data 6. Integration with new fees package: - Import and utilize functions from @caravan/fees for fee calculations - Implement FeeManager class to handle fee-related operations 7. State Management Updates: - Add new reducers for managing pending transactions and fee bump operations - Implement new actions for RBF and CPFP operations - Update selectors to support new state structure

vercel · 2024-08-06T22:55:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
caravan-coordinator	❌ Failed (Inspect)			Sep 7, 2024 9:18pm

Legend101Zz · 2024-08-06T22:57:12Z

Added RBF toggle to transaction creation (Step 1 of RBF/CPFP implementation) .... :)

…transactions view in @caravan/coordinator" This reverts commit 2781e95.

…ence 0xfffffffd in coordinator UI

changeset-bot · 2024-08-26T20:45:55Z

⚠️ No Changeset found

Latest commit: bd4842d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Add a new 'Pending Transactions' tab to the Wallet component, enabling users to easily view and manage pending transactions. This update helps users perform fee bumping actions (RBF, CPFP) when necessary.

Legend101Zz · 2024-08-27T21:14:47Z

This is how the functional Pending Tx Tab looks like ...

bucko13

Looking good so far! Excited to see this hooked up with the fees package.

One additional comment I wanted to add was that it would be nice if the RBF option(s) allowed for an override to fee bump even if the pending tx is not signaling. full-rbf is going to be the default in core soon and there is already a decent chance that fee bumping even without opt-in signaling will work. So maybe you can have a little chip indicating if it's signaling and then allow an option to override with a warning that it might be rejected or not propagate.

bucko13 · 2024-08-28T01:12:17Z

apps/coordinator/src/components/Wallet/WalletPendingTransactions.tsx

+  const walletSlices = useSelector((state: RootState) => [
+    ...Object.values(state.wallet.deposits.nodes),
+    ...Object.values(state.wallet.change.nodes),
+  ]);
+  const blockchainClient = useGetClient();
+
+  useEffect(() => {
+    fetchPendingTransactions();
+  }, [network, walletSlices, blockchainClient]);
+
+  const fetchPendingTransactions = async () => {
+    try {
+      const pendingTxs = walletSlices
+        .flatMap((slice) => slice.utxos)
+        .filter((utxo) => !utxo.confirmed);
+
+      const currentNetworkFeeRate = await getCurrentNetworkFeeRate();
+
+      const analyzedTransactions = await Promise.all(
+        pendingTxs.map(async (utxo) =>
+          analyzeTransaction(utxo, currentNetworkFeeRate),
+        ),
+      );
+
+      setPendingTransactions(analyzedTransactions);
+    } catch (error) {
+      console.error("Error fetching pending transactions:", error);
+      setError("Failed to fetch pending transactions. Please try again later.");
+    } finally {
+      setIsLoading(false);
+    }
+  };


I wonder if this could all be pulled out as a hook, something like useGetPendingTransactions. We'd need some way to set an error from inside the hook though.

bucko13 · 2024-08-28T01:15:28Z

apps/coordinator/src/components/Wallet/fee-bumping/types.ts

@@ -0,0 +1,37 @@
+import { Network } from "@caravan/bitcoin";
+
+export interface UTXO {


these are ultimately going to come from the fees package right?

Yes ... unless I need a custom type to handle some changes

bucko13 · 2024-08-28T01:15:49Z

apps/coordinator/src/components/Wallet/fee-bumping/types.ts

+  utxos: UTXO[];
+}
+
+export interface RootState {


can you move this closer to the actual root store file?

bucko13 · 2024-08-28T01:16:34Z

apps/coordinator/src/components/Wallet/fee-bumping/utils.ts

+import { satoshisToBitcoins } from "@caravan/bitcoin";
+
+export const calculateTimeElapsed = (timestamp: number): string => {
+  const now = Date.now();


the coordinator already has momentjs installed so you could probably use that to do time comparisons a little more easily.

…ponent to a hook

…witness utxo

… improvement and error fixes

cc-unchained · 2024-09-29T21:13:17Z

apps/coordinator/src/reducers/transactionReducer.js

-      inputs: state.inputs.map(convertLegacyInput),
+      inputs: state.inputs.map((input) => ({
+        ...convertLegacyInput(input),
+        sequence: rbfSequence,


So I can see an implementation for the sequence field has been added in the fees package which works with PSBT V2. But as this PR stands, I think the sequence is not persisting in the inputs

inputData logging is coming from packages/caravan-psbt/src/psbtv0/psbt.ts:L90

Working with testnet v4 (merged in #131)

Thanks for the feedback .... I shall move on to resolving this issue and completing the fees package integration, once I am done with completing the last round of reviews on the fees package and getting it merged :)

cc-unchained · 2024-09-29T21:20:46Z

apps/coordinator/src/components/Wallet/fee-bumping/cpfp/CPFPDialog.tsx

+          }
+
+          if (!parentTx) {
+            const parentTxDetails = await blockchainClient.getTransaction(


Noting that this depends on #134

Legend101Zz · 2025-01-05T18:54:18Z

Closing in Favor of PR #168

As we are progressing with a new PR (#168) that addresses the transactions tab functionality and we'll be building a new PR for RBF/CPFP that will build on top of that, so this PR will be closed in favor of that. All relevant updates and discussions will continue in the new PR.

vercel bot deployed to Preview August 6, 2024 22:59 View deployment

Legend101Zz added 2 commits August 27, 2024 01:44

Revert "Implement RBF and CPFP with new fees package and add pending …

efd947f

…transactions view in @caravan/coordinator" This reverts commit 2781e95.

feat: add RBF toggle button and functionality to signal RBF with sequ…

210edc4

…ence 0xfffffffd in coordinator UI

vercel bot deployed to Preview August 26, 2024 20:50 View deployment

feat(coordinator):Introduce 'Pending Transactions' tab for fee bumping

fae5397

Add a new 'Pending Transactions' tab to the Wallet component, enabling users to easily view and manage pending transactions. This update helps users perform fee bumping actions (RBF, CPFP) when necessary.

vercel bot had a problem deploying to Preview August 27, 2024 20:48 Failure

bucko13 reviewed Aug 28, 2024

View reviewed changes

Legend101Zz added 3 commits September 4, 2024 01:29

add fees hook : Code cleaning by taking out the code from pending com…

193ace1

…ponent to a hook

refactor : hooks index file to export fees hook

41b3cc3

changes to package.json and UI improvements in pendingTx table

94df4f1

vercel bot had a problem deploying to Preview September 3, 2024 20:04 Failure

refactor useGetPendingTransactions to give full tx details including …

fd776ad

…witness utxo

vercel bot had a problem deploying to Preview September 6, 2024 21:11 Failure

refactor: Pending Transaction Table ... added additional warning , UI…

9f2142e

… improvement and error fixes

vercel bot had a problem deploying to Preview September 7, 2024 21:12 Failure

Legend101Zz added 3 commits September 8, 2024 02:44

Add : CPFP UI and functionality

7237530

refactor: WalletPendingTransactions

5f3c8f6

Add : RBF UI and functionality

bd4842d

vercel bot had a problem deploying to Preview September 7, 2024 21:18 Failure

Legend101Zz mentioned this pull request Sep 12, 2024

feat: Add getTransaction method to BlockchainClient #134

Merged

cc-unchained reviewed Sep 29, 2024

View reviewed changes

Legend101Zz closed this Jan 5, 2025

		@@ -0,0 +1,37 @@
		import { Network } from "@caravan/bitcoin";

		export interface UTXO {

Conversation

Legend101Zz commented Aug 6, 2024

Uh oh!

vercel bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Legend101Zz commented Aug 6, 2024

Uh oh!

changeset-bot bot commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Legend101Zz commented Aug 27, 2024

Uh oh!

bucko13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Legend101Zz commented Jan 5, 2025

Closing in Favor of PR #168

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Aug 6, 2024 •

edited

Loading

changeset-bot bot commented Aug 26, 2024 •

edited

Loading