Add e2e test for invalid PSBT upload#462
Add e2e test for invalid PSBT upload#462harrshita123 wants to merge 7 commits intocaravan-bitcoin:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Legend101Zz
left a comment
There was a problem hiding this comment.
Just a nit , rest looks good to me thanks for the PR , can you also please attach a screen shot showing the playwright running the test , would be really helpful thanks
.changeset/invalid-psbt-e2e-test.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| "caravan-coordinator": none | |||
There was a problem hiding this comment.
actually we don't need a changeset for this , changeset it for packages and coordinator version , we don't it for e2e test suite ... @bucko13 please correct me if I am wrong here :)
There was a problem hiding this comment.
actually we don't need a changeset for this , changeset it for packages and coordinator version , we don't it for e2e test suite ... @bucko13 please correct me if I am wrong here :)
Thanks for the review and the helpful suggestion!
You are absolutely right . since this change only adds an end-to-end test and does not modify any package code or affect the coordinator version, a changeset isn’t required. I have removed the changeset file accordingly.
I have also attached a screenshot of the Playwright test suite running locally (npm run test:e2e) showing all tests passing, including the newly added invalid PSBT test.
please let me know if there is anything else I should improve!
There was a problem hiding this comment.
actually we don't need a changeset for this , changeset it for packages and coordinator version , we don't it for e2e test suite ... @bucko13 please correct me if I am wrong here :)
Thanks for the review and the helpful suggestion!
You are absolutely right . since this change only adds an end-to-end test and does not modify any package code or affect the coordinator version, a changeset isn’t required. I have removed the changeset file accordingly.
I have also attached a screenshot of the Playwright test suite running locally (npm run test:e2e) showing all tests passing, including the newly added invalid PSBT test.
please let me know if there is anything else I should improve!
There was a problem hiding this comment.
Thanks @harrshita123 everything looks good to me :)

Test / Quality improvement (E2E test)
Fixes #442
This PR adds an end-to-end test to validate Caravan’s behavior when an invalid PSBT file is uploaded.
The test ensures that:
This improves test coverage and prevents regressions related to PSBT validation.
I have tested my changes thoroughly.
I have added tests to cover my changes.
I have run the test suite locally, and all tests pass.
I have written tests for all new changes/features.
I have followed the project's coding style and conventions.
Added E2E test in:
apps/coordinator/e2e/tests/03-transaction_flow.spec.tsVerified locally using
npm run test:e2eHave you read the contributing guide?
Yes