Consolidating ReconstructedUtxo and Coin types into a single ReconstructedCoin type under issue #386#463
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2bb8669 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I may have to update changeset as the checks do not recognize any changeset, also I may have to cross-verify the code and add or updates test suites for the proposed changes @Legend101Zz . |
|
Hi @Legend101Zz please review the changes made to the files - utxoReconstruction.ts and utxo.ts , I have not made any changes to the tests as I did not fully understood the explanation for creating an actual RBF transaction locally. |
Legend101Zz
left a comment
There was a problem hiding this comment.
Thanks for the PR , I'll start looking into it in depth once you move from draft PR , I'll wait for that , until then I'd say that package-lock.json changes should not happen here as there was no package changes involved :)
Sorry sir changes made to the package-lock.json file went unnoticed, it will lead to major problems later on if left unchecked, let me take care of them first. |
…Reconstruction.ts and utxos.ts files
|
Sir @Legend101Zz please review the changes now, I am more confident now and so converting draft to PR. |
What kind of change does this PR introduce?
Refactoring utxoReconstrution.ts file, consolidating ReconstructedUtxo and Coin types into a single ReconstructedCoin type for improved maintainability and redundancy control.
Issue Number:
Fixes #386
Snapshots/Videos:
If relevant, did you update the documentation?
No ( but I updated the comments accordingly )
Summary
Does this PR introduce a breaking change?
Checklist
npm run changeset)Other information
Have you read the contributing guide?
Yes
For information on creating and using changesets, please refer to our documentation on changesets.
I have read the documentation