Skip to content

Consolidating ReconstructedUtxo and Coin types into a single ReconstructedCoin type under issue #386#463

Open
TomLucasakaTGeek wants to merge 6 commits intocaravan-bitcoin:mainfrom
TomLucasakaTGeek:utxo-reconstruct-update
Open

Consolidating ReconstructedUtxo and Coin types into a single ReconstructedCoin type under issue #386#463
TomLucasakaTGeek wants to merge 6 commits intocaravan-bitcoin:mainfrom
TomLucasakaTGeek:utxo-reconstruct-update

Conversation

@TomLucasakaTGeek
Copy link

What kind of change does this PR introduce?

Refactoring utxoReconstrution.ts file, consolidating ReconstructedUtxo and Coin types into a single ReconstructedCoin type for improved maintainability and redundancy control.

Issue Number:

Fixes #386

Snapshots/Videos:

image image image image

If relevant, did you update the documentation?
No ( but I updated the comments accordingly )

Summary

Does this PR introduce a breaking change?

Checklist

  • [ ✅] I have tested my changes thoroughly.
  • [ ✅] I have added or updated tests to cover my changes (if applicable).
  • [✅ ] I have verified that test coverage meets or exceeds 95% (if applicable).
  • [✅ ] I have run the test suite locally, and all tests pass.
  • I have written tests for all new changes/features
  • [✅ ] I have followed the project's coding style and conventions.
  • [ ✅] I have created a changeset to document my changes (npm run changeset)

Other information

Have you read the contributing guide?
Yes

For information on creating and using changesets, please refer to our documentation on changesets.
I have read the documentation

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
caravan-coordinator Error Error Feb 11, 2026 9:04am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

🦋 Changeset detected

Latest commit: 2bb8669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@caravan/bitcoin Patch
@caravan/clients Patch
@caravan/transactions Patch
@caravan/psbt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomLucasakaTGeek
Copy link
Author

I may have to update changeset as the checks do not recognize any changeset, also I may have to cross-verify the code and add or updates test suites for the proposed changes @Legend101Zz .

@TomLucasakaTGeek
Copy link
Author

Hi @Legend101Zz please review the changes made to the files - utxoReconstruction.ts and utxo.ts , I have not made any changes to the tests as I did not fully understood the explanation for creating an actual RBF transaction locally.

@TomLucasakaTGeek TomLucasakaTGeek marked this pull request as ready for review February 7, 2026 15:53
@TomLucasakaTGeek TomLucasakaTGeek marked this pull request as draft February 7, 2026 15:54
Copy link
Contributor

@Legend101Zz Legend101Zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR , I'll start looking into it in depth once you move from draft PR , I'll wait for that , until then I'd say that package-lock.json changes should not happen here as there was no package changes involved :)

@TomLucasakaTGeek
Copy link
Author

Thanks for the PR , I'll start looking into it in depth once you move from draft PR , I'll wait for that , until then I'd say that package-lock.json changes should not happen here as there was no package changes involved :)

Sorry sir changes made to the package-lock.json file went unnoticed, it will lead to major problems later on if left unchecked, let me take care of them first.

@TomLucasakaTGeek TomLucasakaTGeek marked this pull request as ready for review February 11, 2026 09:05
@TomLucasakaTGeek
Copy link
Author

Sir @Legend101Zz please review the changes now, I am more confident now and so converting draft to PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate ReconstructedUtxos and Coin Types to Reduce Complexity

2 participants