feat: BCUR2 wallet registration and address confirmation#468
feat: BCUR2 wallet registration and address confirmation#468cc-unchained wants to merge 3 commits intocaravan-bitcoin:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c4b7afa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bucko13
left a comment
There was a problem hiding this comment.
Couple additional comments but thanks for putting this together!
|
|
||
| export const getColdcardConfig = (walletConfig: MultisigWalletConfig) => { | ||
| const interaction = ConfigAdapter({ | ||
| KEYSTORE: COLDCARD, |
There was a problem hiding this comment.
to keep the code easier to follow, i think it would be good to adapt (pun somewhat intended?) caravan-wallets to accept BCUR2 as the keystore for this as well and return the same thing. Two different keystores can have the same interaction under the hood, but adding that makes it easier to connect menus for example and just select the keystore enum with the interactions without having to convert
|
Wow this worked so slick on my passport my goodness |
d94cd6b to
e4edc61
Compare
e4edc61 to
c3476e0
Compare
c3476e0 to
5af757d
Compare
5af757d to
4ec37f3
Compare
e32bd02 to
46977b3
Compare
46977b3 to
6504688
Compare
c7fbe9e to
235c74c
Compare
235c74c to
c4b7afa
Compare
bucko13
left a comment
There was a problem hiding this comment.
Code looks good! Just going to run through some acceptance testing and I think we can merge in.



What kind of change does this PR introduce?
New feature to enable users to register wallets by scanning BCUR2-compatible QR codes and extends the QR code features to address confirmation flows.
Issue Number:
N/A
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
This MR introduces BCUR2 support for wallet registration and address confirmation functionality. Below is the summary of the changes:
instructionsto allow customization of user instructions displayed with the QR codes inBCUR2Encoder.tsx.RegisterWallet/RegisterBCUR2Button.tsx).BCUR2Encoder.Wallet/RegisterWallet.jsxto include the newRegisterBCUR2Button.Slices/ConfirmAddress.jsx.RegisterWallet/index.jsx.Does this PR introduce a breaking change?
No.
Checklist
npm run changeset)Other information
Have you read the contributing guide?
For information on creating and using changesets, please refer to our documentation on changesets.