e2e: block preview transaction when fee rate is invalid#473
Open
NishDs-06 wants to merge 2 commits intocaravan-bitcoin:mainfrom
Open
e2e: block preview transaction when fee rate is invalid#473NishDs-06 wants to merge 2 commits intocaravan-bitcoin:mainfrom
NishDs-06 wants to merge 2 commits intocaravan-bitcoin:mainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Test improvement / E2E test coverage
Issue Number:
Fixes subtask of #442
Snapshots/Videos:
Not applicable (test-only change)
If relevant, did you update the documentation?
Not applicable
Summary
This PR adds an end-to-end test to ensure that the Preview Transaction step
is not accessible when the fee rate input is invalid.
The test asserts that the system does not expose a forbidden transition
in the Send flow, ensuring users cannot proceed to transaction preview
when required preconditions are not met.
Does this PR introduce a breaking change?
No
Checklist
npm run changeset)Other information
This test validates UI-level state transitions and remains valid even if
backend fee validation logic is refactored, as long as invalid fees must
not allow progression to the Preview step.
Have you read the contributing guide?
Yes