Skip to content

e2e: block preview transaction when fee rate is invalid#473

Open
NishDs-06 wants to merge 2 commits intocaravan-bitcoin:mainfrom
NishDs-06:e2e-invalid-fee-rate
Open

e2e: block preview transaction when fee rate is invalid#473
NishDs-06 wants to merge 2 commits intocaravan-bitcoin:mainfrom
NishDs-06:e2e-invalid-fee-rate

Conversation

@NishDs-06
Copy link

@NishDs-06 NishDs-06 commented Feb 9, 2026

What kind of change does this PR introduce?

Test improvement / E2E test coverage

Issue Number:

Fixes subtask of #442

Snapshots/Videos:

Not applicable (test-only change)

If relevant, did you update the documentation?

Not applicable

Summary

This PR adds an end-to-end test to ensure that the Preview Transaction step
is not accessible when the fee rate input is invalid.

The test asserts that the system does not expose a forbidden transition
in the Send flow, ensuring users cannot proceed to transaction preview
when required preconditions are not met.

Does this PR introduce a breaking change?

No

Checklist

  • I have tested my changes thoroughly.
  • I have added or updated tests to cover my changes (if applicable).
  • I have verified that test coverage meets or exceeds 95% (if applicable).
  • I have run the test suite locally, and all tests pass.
  • I have written tests for all new changes/features
  • I have followed the project's coding style and conventions.
  • I have created a changeset to document my changes (npm run changeset)

Other information

This test validates UI-level state transitions and remains valid even if
backend fee validation logic is refactored, as long as invalid fees must
not allow progression to the Preview step.

Have you read the contributing guide?

Yes

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

⚠️ No Changeset found

Latest commit: af49a70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
caravan-coordinator Ready Ready Preview, Comment Feb 9, 2026 7:33am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant