e2e: Added Tests for importing existing wallet configs and validating wallet config's schema#475
Draft
isid555 wants to merge 1 commit intocaravan-bitcoin:mainfrom
Draft
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
@Legend101Zz Kindly review this draft PR and please suggest any changes to be made if required . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Fixes #442
Importing an existing wallet configuration fileIf relevant, did you update the documentation?
No
Summary
This PR adds automated coverage for importing existing wallet configurations.
Two layers of validation are introduced.
Before touching the UI, the tests assert that wallet configuration files contain all fields required by the application (name, network, address type, client metadata, quorum, and signer information).
This prevents malformed fixtures from producing misleading UI failures and documents the minimum structure the importer relies on.
The fixtures are then uploaded through the wallet import flow and the test verifies that:
Does this PR introduce a breaking change?
No
Checklist
npm run changeset)Other information
All wallet fixtures used by these tests are sourced from:
apps/coordinator/fixtures/caravanHave you read the contributing guide?
Yes
For information on creating and using changesets, please refer to our documentation on changesets.