Skip to content

e2e: Added Tests for importing existing wallet configs and validating wallet config's schema#475

Draft
isid555 wants to merge 1 commit intocaravan-bitcoin:mainfrom
isid555:import_existing_wallet_config
Draft

e2e: Added Tests for importing existing wallet configs and validating wallet config's schema#475
isid555 wants to merge 1 commit intocaravan-bitcoin:mainfrom
isid555:import_existing_wallet_config

Conversation

@isid555
Copy link

@isid555 isid555 commented Feb 9, 2026

What kind of change does this PR introduce?

  • Test Improvement / End-to-End Test Coverage

Issue Number:

Fixes #442 Importing an existing wallet configuration file

If relevant, did you update the documentation?
No

Summary

This PR adds automated coverage for importing existing wallet configurations.

Two layers of validation are introduced.

  1. Fixture schema validation

Before touching the UI, the tests assert that wallet configuration files contain all fields required by the application (name, network, address type, client metadata, quorum, and signer information).
This prevents malformed fixtures from producing misleading UI failures and documents the minimum structure the importer relies on.

  1. End-to-end import verification

The fixtures are then uploaded through the wallet import flow and the test verifies that:

  • the selected network matches the configuration
  • the address type is restored correctly
  • quorum values (required / total) render accurately
  • each signer card displays the expected name, xpub prefix, and BIP32 path
  • the wallet loads successfully without import errors

Does this PR introduce a breaking change?

No

Checklist

  • I have tested my changes thoroughly.
  • I have added or updated tests to cover my changes (if applicable).
  • I have verified that test coverage meets or exceeds 95% (if applicable).
  • I have run the test suite locally, and all tests pass.
  • I have written tests for all new changes/features
  • I have followed the project's coding style and conventions.
  • I have created a changeset to document my changes (npm run changeset)

Other information

All wallet fixtures used by these tests are sourced from: apps/coordinator/fixtures/caravan

Have you read the contributing guide?

Yes

For information on creating and using changesets, please refer to our documentation on changesets.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

⚠️ No Changeset found

Latest commit: b610428

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
caravan-coordinator Ready Ready Preview, Comment Feb 9, 2026 8:34pm

Request Review

@isid555
Copy link
Author

isid555 commented Feb 10, 2026

@Legend101Zz Kindly review this draft PR and please suggest any changes to be made if required .
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End-to-End Testing Coverage

1 participant