Test/638 performance suite #652
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linconvidal
changed the base branch from
operations-parsing-refak
to
develop
linconvidal
changed the base branch from
develop
to
operations-parsing-refak
… to ensure transactions are ordered correctly within blocks (0, 1, 2, ...) and in search results. Changes: - Added txIndex field to TxnEntity JPA entity - Updated JOOQ Transaction and TransactionRecord classes to include TX_INDEX field - Modified TxRepositoryQueryBuilder to select and map tx_index in queries - Updated search query ordering to use (slot DESC, tx_index DESC) - Updated block transaction query to order by tx_index ASC This ensures: - Transactions within blocks are returned in correct order (0, 1, 2, ...) - Search results maintain proper chronological and within-slot ordering - Consistent pagination for /search/transactions API - Proper ordering for /block and /block/transaction endpoints
Remove duplicate dRepVoteDelegation operations from integration test golden files. These duplicates were appearing due to the certificate processing logic creating operations twice. This fix aligns with the TransactionOperationParser refactoring that properly handles DRep vote delegation certificates.
invariants Fixed 4 failing /construction/parse golden tests that had duplicate operations at index 3. Tests expected 5 operations but API correctly returned 4. Added operation invariant tests to prevent ordering bugs: - assert_operations_ordered() - ensures operations sorted by index - assert_operations_sequential() - ensures indices [0, 1, 2, ...] Covers /search/transactions, /block, and /block/transaction endpoints. This would have caught the bug where /construction/parse returns operations in processing order (inputs → outputs → certs → withdrawals) instead of sorted by operation_identifier.index.
linconvidal
force-pushed
the
test/638-performance-suite
branch
from
4c8ce41 to
363bbd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.