Skip to content

Conversation

@ldm0
Copy link
Collaborator

@ldm0 ldm0 commented Dec 15, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a user-configurable tray icon preference that defaults to disabled, allowing users to control whether the application displays a system tray/menu bar icon.

Key changes:

  • Introduces preference storage for tray icon state using localStorage
  • Implements dynamic tray icon enabling/disabling functionality
  • Adds a toggle switch in the preferences UI for user control

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cardinal/src/trayIconPreference.ts New module for managing tray icon preference storage in localStorage
cardinal/src/tray.ts Adds setTrayEnabled function to dynamically enable/disable the tray icon
cardinal/src/main.tsx Removes automatic tray initialization, making it opt-in via preferences
cardinal/src/App.tsx Integrates tray icon state management with preference persistence
cardinal/src/components/PreferencesOverlay.tsx Adds toggle switch UI for controlling tray icon visibility
cardinal/src/App.css Adds styling for the new preference toggle switch component
cardinal/src/i18n/resources/*.json Adds translations for "Show tray icon" label across all supported languages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ldm0 ldm0 merged commit ef32fbc into master Dec 15, 2025
9 checks passed
@ldm0 ldm0 deleted the tray_icon branch December 15, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants