Add convenience/compatibility methods #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactored Errors.
Owner
|
Nice. Could you enclose those finders on its custom module? We could name it "MongoODM::ActiveRecordFinders" or so. BTW, I've pushed a new version with support for BSON::DBRef objects, and referencing / dereferencing of those objects even inside arrays and hashes. |
Owner
|
Ok, now I see that those finders are under a "Finders" module. I'm wondering if that module should be optional or not. What do you think? |
Contributor
Author
|
I so no reason not to include it. Who can have too many convenience functions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements various convenience functions and some of the ActiveRecord API. Should be fully backward compatible, except for the return value on #save.
Note: this includes several un-merged commits from the master branch, you might want to pull master first.