Skip to content

Conversation

@TomMelt
Copy link
Collaborator

@TomMelt TomMelt commented Dec 16, 2024

initial start on lesson 01

@TomMelt TomMelt self-assigned this Dec 16, 2024
@github-actions
Copy link

github-actions bot commented Dec 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/intro-to-modern-fortran/compare/md-outputs..md-outputs-PR-33

The following changes were observed in the rendered markdown documents:

 01-trivial-program.md (new) | 306 +++++++++++++++
 config.yaml                 |   3 +-
 data/exercises.tar.gz       | Bin 359 -> 408 bytes
 introduction.md (gone)      | 220 -----------
 md5sum.txt                  |   6 +-
 renv.lock                   | 924 --------------------------------------------
 6 files changed, 310 insertions(+), 1149 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-06-05 11:55:45 +0000

github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
@vahtras
Copy link
Collaborator

vahtras commented Feb 17, 2025

Is it intentional not to include this new page in config.yaml? Now its content will not show up when you build/serve the lesson.

@TomMelt
Copy link
Collaborator Author

TomMelt commented Mar 17, 2025

nope not intentional. It just isn't ready yet. Feel free to add it.

@astroDimitrios astroDimitrios marked this pull request as draft March 17, 2025 15:33
github-actions bot pushed a commit that referenced this pull request Mar 19, 2025
@astroDimitrios astroDimitrios marked this pull request as ready for review March 19, 2025 17:15
@astroDimitrios
Copy link
Collaborator

astroDimitrios commented Mar 19, 2025

I have added the file to the config and done some re-writing based on the setup / exercise file layout I am proposing in #34.
Rendered episode page

github-actions bot pushed a commit that referenced this pull request Mar 19, 2025
Let's look at that program in more detail:

```bash
cd ~/Desktop/intro-to-modern-fortran/01-trivial-program
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd ~/Desktop/intro-to-modern-fortran/01-trivial-program
cd ~/Desktop/intro-to-modern-fortran/exercises/01-trivial-program

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvalters The setup instructions for the data set: https://www.astropython.com/intro-to-modern-fortran/index.html#data-sets

mean there is no exercises dir when you extract the tar file :)

If this is confusing we can change it.

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025
@theabro
Copy link
Collaborator

theabro commented May 19, 2025

This looks good to me - the only thing I suggest is defining what IO means - currently it's used on line 83 but is not defined.

github-actions bot pushed a commit that referenced this pull request May 27, 2025
@vahtras
Copy link
Collaborator

vahtras commented May 28, 2025

There are to abbreviations for Input/Output, IO and I/O. We should choose one and be consistent throughout the text. I believe I/O is more established.

episodes/01-trivial-program.md:We will cover IO (Input/Output) in a later episode.
episodes/introduction.Rmd:detail in the context of i/o to external files.

github-actions bot pushed a commit that referenced this pull request May 28, 2025
@astroDimitrios
Copy link
Collaborator

There are to abbreviations for Input/Output, IO and I/O. We should choose one and be consistent throughout the text. I believe I/O is more established.

episodes/01-trivial-program.md:We will cover IO (Input/Output) in a later episode.
episodes/introduction.Rmd:detail in the context of i/o to external files.

Thanks @vahtras I think we should go with I/O - I have updated the first instance.
You also reminded me that we need to get rid of the introduction.Rmd file (which had the old ARCHER2 placeholder content) so I have deleted it :)

Fix missing full stop.

Co-authored-by: Warrick Ball <warrickball@gmail.com>
github-actions bot pushed a commit that referenced this pull request Jun 2, 2025
github-actions bot pushed a commit that referenced this pull request Jun 5, 2025
@dvalters
Copy link
Collaborator

I shall add a review very soon - sorry I've been away on leave for a while and missed the last session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants