-
-
Notifications
You must be signed in to change notification settings - Fork 6
WIP: initial start on lesson #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/intro-to-modern-fortran/compare/md-outputs..md-outputs-PR-33 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-06-05 11:55:45 +0000 |
|
Is it intentional not to include this new page in config.yaml? Now its content will not show up when you build/serve the lesson. |
|
nope not intentional. It just isn't ready yet. Feel free to add it. |
|
I have added the file to the config and done some re-writing based on the setup / exercise file layout I am proposing in #34. |
| Let's look at that program in more detail: | ||
|
|
||
| ```bash | ||
| cd ~/Desktop/intro-to-modern-fortran/01-trivial-program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cd ~/Desktop/intro-to-modern-fortran/01-trivial-program | |
| cd ~/Desktop/intro-to-modern-fortran/exercises/01-trivial-program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvalters The setup instructions for the data set: https://www.astropython.com/intro-to-modern-fortran/index.html#data-sets
mean there is no exercises dir when you extract the tar file :)
If this is confusing we can change it.
|
This looks good to me - the only thing I suggest is defining what IO means - currently it's used on line 83 but is not defined. |
|
There are to abbreviations for Input/Output, IO and I/O. We should choose one and be consistent throughout the text. I believe I/O is more established. |
Thanks @vahtras I think we should go with I/O - I have updated the first instance. |
Fix missing full stop. Co-authored-by: Warrick Ball <warrickball@gmail.com>
|
I shall add a review very soon - sorry I've been away on leave for a while and missed the last session |
initial start on lesson 01