added conditional extension delimiter#70
Open
calebanderson wants to merge 2 commits intocarr:masterfrom
Open
Conversation
added 2 commits
August 19, 2015 21:11
Collaborator
|
@calebanderson I dig the idea. Did you give any thought to using a token related to |
Author
|
@elskwid I did originally, but that ended up looking like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Characters wrapped in
%d{}only appear when the extension is present. This would be able to be merged in now without changing any of the old behavior and allow an amount of flexibility that is quite useful.I completely understand if this isn't in the spirit of the gem and doesn't get merged, but I found it useful and thought you might like the idea.