Customisations for german phone numbers#79
Open
Skudo wants to merge 3 commits intocarr:masterfrom
Skudo:customisations-for-german-phone-numbers
Open
Customisations for german phone numbers#79Skudo wants to merge 3 commits intocarr:masterfrom Skudo:customisations-for-german-phone-numbers
Skudo wants to merge 3 commits intocarr:masterfrom
Skudo:customisations-for-german-phone-numbers
Conversation
…umbers. Given a text file with (most) known German area codes, phone numbers are parsed accordingly. As a fallback, we keep the default provided by `countries.yml`, because the list does not know about "service area codes", mobile phone area codes etc. This however should handle all landline area codes in Germany.
…its. According to the regulation office, German phone numbers are recommended to have no more than 15 digits, including country code and area code, but excluding leading zeros. Given 2-digits area codes, that's up to 11 digits for the "remainder" of a phone number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two "features" of German phone numbers.
country code + area code + numberis 15, which meansnumbercan be up to 11 digits long.