Handle where phone number has country code prefix but without plus sign#82
Open
jpawlyn wants to merge 1 commit intocarr:masterfrom
Open
Handle where phone number has country code prefix but without plus sign#82jpawlyn wants to merge 1 commit intocarr:masterfrom
jpawlyn wants to merge 1 commit intocarr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may cause problems in some edge cases I'm guessing but I was experiencing issues when phone numbers with the country code but without the '+' were being given. ie
This was returning nil and now this pull request enables the number to be parsed successfully.