Open
Conversation
context managers, tuple unpacking, enumerate all should be used.
CoolCat467
approved these changes
Jun 11, 2022
Author
I've seen both f and file, with f obviously being short for file, but uhh, I think it's clear enough |
Schuwi
reviewed
Jul 5, 2022
| for elem in schedules[4]: | ||
| timestamp, _, phoneme = elem.split(",") | ||
| framestamp = timestepToFrames(float(timestamp)) | ||
| if i >= 1 and framestamp <= phonemeTimeline[-1][1]: # we have a 0-frame phoneme! Try to fix it. |
There was a problem hiding this comment.
The index i is used here but you removed it
Schuwi
reviewed
Jul 5, 2022
| phoneme = parts[2] | ||
| phonemeTimeline.append([phoneme,framestamp]) | ||
| phonemeTimeline.append(["end",FRAME_COUNT]) | ||
| phonemeTimeline.append([phoneme, framestamp]) |
There was a problem hiding this comment.
Fix with phoneme = parts[2] as original had it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context managers, tuple unpacking, enumerate all should be used.