Silence warning -Wconversion in GCC 15.2 and -Wsign-conversion in Clang 21.1.8#3061
Open
hanickadot wants to merge 2 commits intocatchorg:develfrom
Open
Silence warning -Wconversion in GCC 15.2 and -Wsign-conversion in Clang 21.1.8#3061hanickadot wants to merge 2 commits intocatchorg:develfrom
hanickadot wants to merge 2 commits intocatchorg:develfrom
Conversation
hanickadot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3061 +/- ##
=======================================
Coverage 91.14% 91.15%
=======================================
Files 202 202
Lines 8831 8832 +1
=======================================
+ Hits 8049 8050 +1
Misses 782 782 🚀 New features to boost your workflow:
|
horenmar
reviewed
Jan 18, 2026
|
|
||
| auto colInfo = tp.m_columnInfos[tp.m_currentColumn]; | ||
| auto colInfo = | ||
| tp.m_columnInfos[static_cast<size_t>( tp.m_currentColumn )]; |
Member
There was a problem hiding this comment.
tp.m_currentColumn should be changed to be unsigned instead. The only place where it uses the fact that it is signed is using -1 as guard value after reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This small PR add explicit cast from
size_ttointwhen callingstd::setw(...)to silence warning produced by GCC 15.2.This also fixes conversions between sign types in Clang 21.1.8.