Solution refactor #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert from layer-based structure - Fix naming inconsistencies (e.g. UserController -> ApplicationUserController)
- reorganise directory structure and rename files for consistency - update components to use modern syntax - fix Vite config
- rename using camel-case for consistency - move test setup file to utils
harish-janardhanan
requested changes
Oct 22, 2025
Collaborator
harish-janardhanan
left a comment
harish-janardhanan
left a comment
There was a problem hiding this comment.
Can we leave the project as is? There’s feedback from the cohort that the last merge caused a lot of conflict on the progress that’s been made on their side.
Contributor
Author
|
@harish-janardhanan Yes, I won't merge any further changes until this cohort completes their assessment. The students were instructed not to apply any of the upstream updates, but some managed to do so, all the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, but builds on the fixes in previous PR to improve the code organisation:
I made this a separate PR as it changes the directory structure of the backend application quite significantly and it might deviate further from the original than is desired by UBS team.
Please let me know if any amendments would be required