#32 Use ctrl-enter or meta-enter to submit form when on a textarea#44
Open
milofultz wants to merge 2 commits intocblgh:mainfrom
Open
#32 Use ctrl-enter or meta-enter to submit form when on a textarea#44milofultz wants to merge 2 commits intocblgh:mainfrom
milofultz wants to merge 2 commits intocblgh:mainfrom
Conversation
84ebfff to
220cb6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles issue #32. This adds an event listener on the
new-threadand thethreadpages. Essentially what happens is, given they are on one of these two threads,I used
ctrlandmetato handle the major OS's (assuming Linux's main command key is one of those two).Comments
forEachon each textarea that existed in aformfor each page just in case there was ever a page with multiple. If this is overkill, I can remove it.scripts, but didn't want to try and change much of the core functions to make that happen as that seemed like way too much of an edge case. Using the prefix ofscripts.seemed like the best compromise, but a compromise nonetheless.I'm not precious about PR's. If you want to modify it, merge it, decline it, whatever, go for it. Thanks!