Ci deployments #26
Open
Ci deployments #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Packer configuration to support container-based builds by introducing CD-based provisioning for vSphere, updating boot commands, and making Ansible paths configurable.
- Renamed
bootcommandvariable toboot_commandfor consistency with Packer conventions - Updated boot commands to use CD-based cloud-init (nocloud) instead of HTTP-based provisioning
- Added configurable variables for port ranges, IP addresses, and Ansible file paths
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variables.auto.pkr.hcl | Renamed boot command variable and added new variables for port configuration and Ansible paths |
| ubuntu24.pkrvars.hcl | Updated boot command to use nocloud datasource and upgraded Ubuntu 24.04 ISO to version 24.04.3 |
| ubuntu2204.pkrvars.hcl | Updated boot command to use nocloud datasource for Ubuntu 22.04 |
| ubuntu.pkr.hcl | Applied boot_command variable rename, added CD files configuration for vSphere, made Ansible paths configurable |
| http/user-data | Added open-vm-tools package and user-data configuration for root disabling and timezone |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| http_port_min = 49152 | ||
| cd_files = [ | ||
| "./http/meta-data", | ||
| "./http/user-data"] |
There was a problem hiding this comment.
[nitpick] The closing bracket should be on the same line as the last element or the array should use consistent multi-line formatting. Current formatting mixes single-line and multi-line style.
Suggested change
| "./http/user-data"] | |
| "./http/user-data" | |
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can build in containers