Skip to content

removing facebook pop up error #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

removing facebook pop up error #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f023715
error was lowercase instead of upper case
IdoBn May 16, 2014
e61ba18
facebook gave an error about popup
IdoBn May 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions www/js/openfb-angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ angular.module('openfb', [])
function login(fbScope) {

if (!fbAppId) {
return error({error: 'Facebook App Id not set.'});
return Error({error: 'Facebook App Id not set.'});
}

var loginWindow;
Expand Down Expand Up @@ -84,7 +84,7 @@ angular.module('openfb', [])
}

loginWindow = window.open(FB_LOGIN_URL + '?client_id=' + fbAppId + '&redirect_uri=' + oauthRedirectURL +
'&response_type=token&display=popup&scope=' + fbScope, '_blank', 'location=no');
'&response_type=token&scope=' + fbScope, '_blank', 'location=no');

// If the app is running in Cordova, listen to URL changes in the InAppBrowser until we get a URL with an access_token or an error
if (runningInCordova) {
Expand Down