make 'import serial' dependency sometimes optional#46
Open
thejoshwolfe wants to merge 1 commit intoccwienk:masterfrom
Open
make 'import serial' dependency sometimes optional#46thejoshwolfe wants to merge 1 commit intoccwienk:masterfrom
thejoshwolfe wants to merge 1 commit intoccwienk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have a tty device, only a hidraw device. I imagine many people only have 1 device they want to support, so the tty-specific dependency doesn't apply to some people (including me).
This PR prints a warning on failure to
import serialinstead of exiting with an error, and the warning explains what's going to work and not work.Here's what it looks like with a hidraw device without and with the serial system dependency:
for a tty device, the situation would look something like this: (I tested this by hacking the code to artificially hit this codepath because i don't have a tty device.)