Skip to content

Conversation

@puc9
Copy link
Contributor

@puc9 puc9 commented Oct 20, 2025

Description

This is my experiment on using all ruff rules and updating the code base to most recent Python recommendations.
Feel free to borrow anything, merging it as is may be too large of a change.
Event callback type annotations are still a challenge to get right, still working on it.

Also, feel free to close it, I created it just as an FYI.

Pre-merge Checklist

  • I have described my change in the section above.
  • I have ran the ./scripts/format.sh and ./scripts/lint.sh scripts. My code is properly formatted and has no linting errors.
  • I have ran uv run pytest and ensured all tests pass.
  • I have added my change to CHANGELOG.md under the [Unreleased] section.

@stephanlensky
Copy link
Member

What exactly did you do here? The code is already formatted with ruff. The CDP files are excluded on purpose because they are auto-generated and should never be edited by hand. No need to format.

Unfortunately we can't use the most modern Python features because we need to keep compatibility back to Python 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants