Skip to content

Conversation

@hvgupta
Copy link
Contributor

@hvgupta hvgupta commented Oct 31, 2025

Description

  • simplified the xpath implementation
  • xpath does not raise an exception now as written in the function description (try, finally does not catch the error)

Pre-merge Checklist

  • I have described my change in the section above.
  • I have ran the ./scripts/format.sh and ./scripts/lint.sh scripts. My code is properly formatted and has no linting errors.
  • I have ran uv run pytest and ensured all tests pass.
  • I have added my change to CHANGELOG.md under the [Unreleased] section.

@hvgupta hvgupta requested a review from a team as a code owner October 31, 2025 01:57
Copy link
Member

@stephanlensky stephanlensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! FYI, I think this code is failing some formatting checks. I'll merge and then fix it for you.

@stephanlensky stephanlensky merged commit b38d12d into cdpdriver:main Nov 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants