fix(network): KeyError on Chrome 146 due to CDP privateNetworkRequestPolicy rename#250
Open
tabmadi wants to merge 1 commit intocdpdriver:mainfrom
Open
fix(network): KeyError on Chrome 146 due to CDP privateNetworkRequestPolicy rename#250tabmadi wants to merge 1 commit intocdpdriver:mainfrom
tabmadi wants to merge 1 commit intocdpdriver:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Chrome 146 renamed the CDP field
privateNetworkRequestPolicytolocalNetworkAccessRequestPolicyin theNetwork.requestWillBeSentExtraInfoevent'sclientSecurityStateobject. This causes zendriver to throw aKeyErroron nearly every network request, flooding logs with tracebacks.The fix updates
ClientSecurityState.from_jsoninzendriver/cdp/network.pyto accept both the old and new key name, maintaining backward compatibility with older Chrome versions.Fixes #249
Pre-merge Checklist
./scripts/format.shand./scripts/lint.shscripts. My code is properly formatted and has no linting errors.uv run pytestand ensured all tests pass. (93 passed, 1 pre-existing failure intest_keyinputs.py::test_visible_events[headless1]— unrelated to this change.)[Unreleased]section.