Conversation
| <!-- TODO: Replace <version-number> with the latest version number to receive corresponding updates of the GC Design System utility framework. All notable changes will be documented in the changelog: https://github.com/cds-snc/gcds-utility/blob/main/CHANGELOG.md --> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://cdn.design-system.alpha.canada.ca/@cdssnc/gcds-utility@1.4.0/dist/gcds-utility.min.css" |
There was a problem hiding this comment.
Could we switch out the fixed version number here for @<version-number>? That would be awesome, thanks!
melaniebmn
left a comment
melaniebmn
left a comment
There was a problem hiding this comment.
Added some comments! It's cool to see another template come to life :)
| ></script> | ||
| <script | ||
| nomodule | ||
| src="https://cdn.design-system.alpha.canada.ca/@cdssnc/gcds-components@0.26.3/dist/gcds/gcds.js" |
There was a problem hiding this comment.
Same comment about the fixed version for these 3 links.
| columns-tablet="1fr 1fr" | ||
| > | ||
| <!-- TODO: Update the Featured image --> | ||
| <img src="https://dummyimage.com/360x203/000000/FFFFFF.png" alt="" class="img-full"> |
There was a problem hiding this comment.
Debating this in my mind, would it be helpful to have alt text here that says something like "Provide descriptive alt-text for the accompanying image"? We can go either way.
There was a problem hiding this comment.
I like having this guidance but I think it might be better to add it as a comment above. I fear if it was in the alt attribute, some people would end up leaving it there and only replace the image source.
3 participants
Summary | Résumé
Add HTML templates of the Topic page.
Pull request only contains English version for now.
Todo: