-
Notifications
You must be signed in to change notification settings - Fork 18
Dev Workflow for Pushes to 'dev' Branch #2719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new GitHub Actions workflow to automatically build and push Docker images to the development ECR repository when changes are pushed to the dev branch. Additionally, it simplifies the staging lambda workflow by removing New Relic conditional logic.
Key changes:
- New automated workflow for building both lambda and k8s images on dev branch pushes
- Simplified staging lambda workflow by removing New Relic-specific Dockerfile selection logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/dev_branch_build_push_images.yaml |
New workflow that builds and pushes api-lambda-dev and api-dev images to dev ECR on pushes to dev branch |
.github/workflows/lambda_staging.yml |
Removed New Relic environment variable detection and conditional Dockerfile selection logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ben851
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…using the new roles in TF
ben851
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary | Résumé
new workflow to handle building and deploying images to our dev ECR on dev branch changes
Related Issues | Cartes liées
https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/741
Reviewer checklist | Liste de vérification du réviseur