Skip to content

Conversation

@P0NDER0SA
Copy link
Contributor

Summary | Résumé

new workflow to handle building and deploying images to our dev ECR on dev branch changes

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/741

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copilot AI review requested due to automatic review settings December 2, 2025 14:07
@P0NDER0SA P0NDER0SA requested a review from jimleroyer as a code owner December 2, 2025 14:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new GitHub Actions workflow to automatically build and push Docker images to the development ECR repository when changes are pushed to the dev branch. Additionally, it simplifies the staging lambda workflow by removing New Relic conditional logic.

Key changes:

  • New automated workflow for building both lambda and k8s images on dev branch pushes
  • Simplified staging lambda workflow by removing New Relic-specific Dockerfile selection logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/dev_branch_build_push_images.yaml New workflow that builds and pushes api-lambda-dev and api-dev images to dev ECR on pushes to dev branch
.github/workflows/lambda_staging.yml Removed New Relic environment variable detection and conditional Dockerfile selection logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants