Skip to content

feat: Decimal Functionality for Number Fields #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ShadeWyrm wants to merge 7 commits into
base: feature/canary
Choose a base branch
from
Open

feat: Decimal Functionality for Number Fields #6589

ShadeWyrm wants to merge 7 commits into from

Conversation

@ShadeWyrm
Copy link
Contributor

@ShadeWyrm ShadeWyrm commented Dec 17, 2025 •
edited
Loading

Closes #6492
Closes #6249
Closes #6452
Part of #4683

  • Adds decimal values to the numbers component that can be customized on # of decimals 0 or more.
  • Fixes an issue with numeric properties appearing in the "More" box for other text fields that aren't numbers.
  • Value sent to the system is always XXXX.XX format to ensure standard machine readability.
  • HTML Output use the Decimal Seperator that's expected of the Language. JSON and CSV remains "." for machine readable numbers.
  • Display Value now accounts for user language toggle, updating as necessary without impacting stored value.

@github-actions github-actions bot added the !! Package Update !! Please ensure packages are built and pushed label Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

🧪 Review environment

https://obrj6opr4un7jhzcnpsozbzepy0bmkga.lambda-url.ca-central-1.on.aws/

@ShadeWyrm ShadeWyrm marked this pull request as ready for review December 18, 2025 17:16
@anikbrazeau anikbrazeau mentioned this pull request Dec 23, 2025
Open
6 tasks
anikbrazeau
anikbrazeau reviewed Dec 29, 2025
View reviewed changes
anikbrazeau
anikbrazeau reviewed Dec 29, 2025
View reviewed changes
@timarney timarney changed the base branch from main to feature/canary December 29, 2025 17:13
@timarney timarney changed the base branch from feature/canary to main December 29, 2025 17:14
@ShadeWyrm ShadeWyrm force-pushed the feat/decimal-places-for-numbers branch from 6471967 to f088506 Compare December 29, 2025 17:25
@ShadeWyrm ShadeWyrm changed the base branch from main to feature/canary December 29, 2025 17:25
@anikbrazeau
Copy link
Member

anikbrazeau commented Dec 29, 2025

Possible to add a bit of spacing before this option in the "More" menu?

Screenshot 2025-12-29 at 1 20 43 PM

@Abi-Nada
Copy link

Abi-Nada commented Dec 29, 2025

Tested and LGTM!

@timarney timarney force-pushed the feat/decimal-places-for-numbers branch from 02c00c5 to be79084 Compare January 2, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikbrazeau anikbrazeau anikbrazeau left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

!! Package Update !! Please ensure packages are built and pushed

Projects

None yet

Milestone

No milestone

4 participants

@ShadeWyrm @anikbrazeau @Abi-Nada