Draft
Conversation
Staged files:\n- graph-frontend/src/components/Graph.tsx\n\nMove loadGraph(graph) before sigma.refresh() to avoid refreshing stale graph state, and include sigma in the useEffect dependency array so the effect re-runs if the Sigma instance changes. Co-authored-by: cdxker <cdxker@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
cdxker
force-pushed
the
spotify-integration
branch
from
4961241 to
8d78f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder
loadGraphandsigma.refreshcalls and addsigmato theuseEffectdependency array.The previous order caused
sigma.refresh()to run with the old graph state, leading to a wasted refresh and potential visual flash. Additionally,sigmawas missing from the dependency array, preventing the effect from re-running if thesigmainstance changed.