Skip to content

Updated warning message on unreachable, fixed bug with variable query #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwest77a merged 1 commit into from
Jun 24, 2025
Merged

Updated warning message on unreachable, fixed bug with variable query #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ceda_datapoint/core/cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,12 @@ def _prepare_dataset(
datetime = self._meta['search_terms'].get('datetime',None)
# Datetime can only be applied to 'time' dimension.

query = self._meta['search_terms'].get('query',{})
vq = query.get('variables',None)
query = self._meta['search_terms'].get('query',[])

vq = None
for ql in query:
if 'variables' in ql:
vq = ql.split('=')[-1]

variables = self._data_selection.get('variables',None) or vq
sel = self._data_selection.get('sel',None)
Expand Down
7 changes: 7 additions & 0 deletions ceda_datapoint/core/item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,13 @@ def _load_cloud_assets(
mapper=mapper, data_selection=self._data_selection)
if show_unreachable or a.visibility != 'unreachable':
asset_list.append(a)
else:
if a.visibility == 'unreachable':
logger.warning(
f'Dataset for {self._id} not reachable - use '
'show_unreachable=True in search.collect_cloud_assets() '
'to obtain the product object.'
)


if len(asset_list) == 0:
Expand Down