-
Notifications
You must be signed in to change notification settings - Fork 15
chore(test-project): Migrate tasks.js and util.js to ESM/TS #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cedarjs canceled.
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 3s | View ↗ |
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 6s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 10s | View ↗ |
nx run-many -t build |
✅ Succeeded | 5s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-04 18:54:45 UTC
6df58f3 to
ff06e42
Compare
Greptile SummaryThis PR successfully migrates Key Changes:
Technical Details:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Node as Node.js
participant Tasks as tasks.mts
participant Util as util.mts
participant Execa as execa
participant TS as TypeScript
Dev->>Node: Run native node (24+) script
Node->>Tasks: Import with .mts extension
Tasks->>Util: Import functions from util.mts
Note over Tasks,Util: ESM imports require explicit .mts extensions
Tasks->>Tasks: Set OUTPUT_PATH with type checking
Tasks->>Util: Call exec(cmd, args[], options)
Note over Util,Execa: exec signature now requires args array
Util->>Execa: execa(cmd, args, options)
Execa-->>Util: Returns promise with result
Util->>Util: Handle ExecaError with typed properties
Util-->>Tasks: Return typed execution result
Tasks->>TS: Type checking with interfaces
Note over Tasks,TS: WebTasksOptions, ApiTasksOptions provide type safety
Tasks-->>Node: Execute tasks with full type safety
Node-->>Dev: Native ESM execution complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
38e101d to
c0af846
Compare
c0af846 to
d416ed3
Compare
ef0a462 to
59c3d3e
Compare
|
@greptileai please do a full review again, and update your summary |

This PR migrates a couple of files for test-project generation from JavaScript to ESM-compliant TypeScript.
allowImportingTsExtensionsandnoEmitintasks/tsconfig.jsonto support the required ESM import syntax.Verification:
yarn build:test-project --helpusing native node to confirm execution.yarn tsc -p tasks/tsconfig.json.