Skip to content

fix rpc url timeouts #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronmgdr wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −4
Open

fix rpc url timeouts #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a81b4c
Add metadata timeouts for slow rpc urls
aaronmgdr Dec 19, 2025
b67e3e6
docs(changeset): Set a max wait time when fetching community rpc prov…
aaronmgdr Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-nights-draw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@celo/celocli': patch
---

Set a max wait time when fetching community rpc provider metadata urls.
10 changes: 6 additions & 4 deletions packages/cli/src/commands/validatorgroup/rpc-urls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,16 @@ export default class RpcUrls extends BaseCommand {
ux.action.start(`Fetching RPC URLs`)
const rpcUrls = await concurrentMap(CONCURRENCY_LEVEL, validatorAddresses, async (address) => {
const metadataURL = rpcNodeMetaDataUrls.get(address)

if (!metadataURL) {
return undefined
}

try {
const metadata = await IdentityMetadataWrapper.fetchFromURL(accountsWrapper, metadataURL)

const metadata = await Promise.race([
IdentityMetadataWrapper.fetchFromURL(accountsWrapper, metadataURL),
new Promise<never>((_, reject) =>
setTimeout(() => reject(new Error('Timeout')), 6_000)
)
])
return metadata.findClaim(ClaimTypes.RPC_URL)?.rpcUrl
} catch (_) {
return undefined
Expand Down
Loading