Remove creation of .params file in phase 2 combine#80
Open
mstraka100 wants to merge 4 commits intomasterfrom
Open
Remove creation of .params file in phase 2 combine#80mstraka100 wants to merge 4 commits intomasterfrom
mstraka100 wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the generation of the
.paramsfile when runningcombineinphase2-cli. This file duplicates information in the combined file and serves no apparent purpose. Tested by runninge2e/e2ephase1.shande2e/e2ephase2.shsequentially in the head commit of the main branch33717c3b0869c605e6c3627446e916f268712e00of https://github.com/celo-org/snark-setup-operator