Conversation
The patch moves run_mon_job and accompanying functions to cthulhu manager. It also removes RemoteViewset since it only contain the run_mon_job and two other accompanying function. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1273559 Fixes: http://tracker.ceph.com/issues/14440 Signed-off-by: Boris Ranto <branto@redhat.com>
2b679e8 to
4771d19
Compare
|
This PR dropped the patch for the 1.4 issue and now, it contains only the patch for the 1.3 issue. |
|
I’m so happy see this PR, I have the same idea recently. |
|
@syf-zsxm FWIW: we are gonna move the function only for 1.3, the 1.4 branch does not need this change since it does not present this issue. The 10s timeout seems like a short one, maybe we should look at a way to make it 30s? (or configurable maybe?) |
@b-ranto Good idea. We can specify the value of heartbeat when def zerorpc.Client and zerorpc.Server. And in But how long is suitbale? |
|
|
||
| # TODO: in order to support radosgw-admin commands we might need to be able to identify running RGW services | ||
| # alternatively it may be possible to run radosgw-admin on a mon node that isn't running the RGW service | ||
| mon_fqdns = self._get_up_mon_servers(fsid) |
There was a problem hiding this comment.
What about use self._fs_resolve(fs_id)._favorite_mon instead
This patchset fixes
https://bugzilla.redhat.com/show_bug.cgi?id=1273559
for 1.3 and
https://bugzilla.redhat.com/show_bug.cgi?id=1347137
for 1.4 (once "backported" for 1.4).
I've tested this on my local cluster and it fixed both the bugs for me (for 1.3 branch).