nvmeof: add auto listeners feature into NVMe-oF CSI driver #5891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps to the devel latest. proto file in nvmeof repo has been updated. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
gadididi
changed the title
add ListListeners grpc query to fetch the current listener list for specific subsystem. added because auto-listener feature creates automatically listeners, and the listeners list is needed for the node-server. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
add the option "networkMask" in SC. This
option is intoduced to replace the listener list entry
in the SC. with this param the admin does need to know
what are GWs IPs. just needs to provide the network mask
of the deployment. one way to get it, by run
`oc get network.config/cluster -o \
jsonpath='{.status.clusterNetwork[*].cidr}'`
then, assign the value in networkMask field,
and that's it.
Signed-off-by: gadi-didi <gadi.didi@ibm.com>
add the networkMask param into create subsystem call. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
gadididi
force-pushed
the
nvmeof/add_auto_listeners
branch
from
99962d5 to
2d1d4eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Add new option in nvmeof storageClass "networkMask" . This property can replace the exists property "listeners"
Instead of search and add every GW ip and host name in SC and every redeploy the GW the Admin should reedit this file.. the admin just need by one searching of the subnet mask of the deployment, and add it to the SC , and that's it!
the Auto listener feature was merged into nvmeof GW:
ceph/ceph-nvmeof#1381
it means, the nvmeof creates the listeners automictically, and no need to provide the IPs. it searches them by its own.
Is there anything that requires special attention
Future concerns
once this PR #5890 is merged, rebase this PR to devel and can review it.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)