rbd: fetch the volumeIds from VGRContent's status for omap data #5899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
reviewed
Jan 6, 2026
Member
nixpanic
left a comment
nixpanic
left a comment
There was a problem hiding this comment.
I assume that when fetching the PV fails, a new reconcile is scheduled?
internal/controller/volumegroup/volumegroupreplicationcontent.go
Outdated
Show resolved
Hide resolved
Contributor
Author
Yes, it will trigger a new reconcile. |
Nikhil-Ladha
force-pushed
the
fetch-vols-from-vgrc-status
branch
from
ee9b0d3 to
59629e7
Compare
nixpanic
previously approved these changes
Jan 6, 2026
Madhu-1
requested changes
Jan 6, 2026
internal/controller/volumegroup/volumegroupreplicationcontent.go
Outdated
Show resolved
Hide resolved
Nikhil-Ladha
force-pushed
the
fetch-vols-from-vgrc-status
branch
from
59629e7 to
4189187
Compare
nixpanic
approved these changes
Jan 6, 2026
Madhu-1
approved these changes
Jan 7, 2026
Contributor
|
@Mergifyio rebase |
Currently, we fetch the volumeId's from VGRContent.Spec.Source which has all the volumes that should be part of the group. But, it might happen that the initial modify call might fail due to some reason like network/config issue. In that case, the volumegroup omap will already be updated with the volumeIds and subsequent ModifyVolumeGroup call will fail as the volumes before and after Modify operation is same. Therefore, we should fetch the volumeIds from the VGRContent status, which only gets updated post a succesfull modification. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Contributor
✅ Branch has been successfully rebased |
ceph-csi-bot
force-pushed
the
fetch-vols-from-vgrc-status
branch
from
4189187 to
d20b696
Compare
Contributor
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at e62e083 |
Contributor
Merge Queue Status✅ The pull request has been merged at d20b696 This pull request spent 2 hours 45 minutes 27 seconds in the queue, including 2 hours 39 minutes 23 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Currently, we fetch the volumeId's from VGRContent.Spec.Source which has all the volumes that should be part of the group. But, it might happen that the initial modify call might fail due to some reason like network/config issue. In that case, the volumegroup omap will already be updated with the volumeIds and subsequent ModifyVolumeGroup call will fail as the volumes before and after Modify operation is same.
Therefore, we should fetch the volumeIds from the VGRContent status, which only gets updated post a succesfull modification.