include <cstdint> wherever missing #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@rzarzynski @markhpc I am not sure if I am targetting the right branch but IIUC this is the branch that gets cloned for Ceph rocksdb submodule. |
rishabh-d-dave
changed the title
rishabh-d-dave
changed the title
Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
force-pushed
the
ceph-reef-v7.9.2-missing-cstdint
branch
from
9999696 to
099c148
Compare
rzarzynski
approved these changes
Sep 2, 2025
rzarzynski
left a comment
rzarzynski
left a comment
There was a problem hiding this comment.
Yes, the target branch seems correct.
After merging this into ceph/rocksdb, we will need another commit in ceph/ceph for bumping the submodule.
|
CC: @aclamk. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors like that are seen while building Ceph repo's main branch on Fedora 42 -