-
-
Notifications
You must be signed in to change notification settings - Fork 97
chore(overmind-devtools): ensure deps are explicitly manifested #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
chore(overmind-devtools): ensure deps are explicitly manifested #618
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think babel and webpack plug-ins should be under "devDependencies", as they are not used by the runtime but only for development.
You also should make sure that the deps are in sync with the deps in the root of the monorepo. You can check this by running npm run checkdeps from the root folder. After fix it manually as fixdeps doesn't really works as expected.
When you run npm install from the root folder of the monorepo all packages will be linked and build. Don't install dependencies in the package folders as this destroys the linking. All packages should be installed from the root folder during development.
BTW it seems there is a conflict. Make sure you start with the next branch.
|
BTW I have no idea why |
|
@henri-hulski I'll do how you advised - also documenting in the main readme (?) on how to proceed with bumping and maintaining dependencies. |
|
Sure! I think that would help maintaining overmind. |
henri-hulski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Damian! Could you take a look at the review and fix it? Then I will merge it.
| "devtool" | ||
| ], | ||
| "dependencies": { | ||
| "@babel/plugin-transform-runtime": "^7.24.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All webpack and babel related dependencies are devDependencies not dependencies as they're only needed for development, not when you install the npm package (npm install overmind-devtools).
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-icons": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-icons is ok (should be) in dependencies as it's used directly in the code.
| @@ -1,3 +1,22 @@ | |||
| # overmind-devtools | |||
| ### Introduction | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave # overmind-devtools so that we know where we are and underneath use ## not ###. Otherwise I get linting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also seems like you need to rebase as there were some changes in package.json.
Btw I'm just starting to fix the start scripts. For overmin-devtools-client I was able to make the web-client work.
I also want to take a look why npm start doesn't work in this repo.
2d3ee49 to
f2d7b68
Compare
1352333 to
051354f
Compare
In this tiny PR:
package.json- local development can be started