-
Notifications
You must be signed in to change notification settings - Fork 0
feat: button component #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rfaria107
wants to merge
9
commits into
main
Choose a base branch
from
rf/button-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3daf5dc
feat: button component
rfaria107 797d6e0
small-fixes
rfaria107 877e919
Fix: updated and simplified Props + Storybook
rfaria107 8d58263
Merge remote-tracking branch 'origin/main' into rf/button-component
rfaria107 a5537fb
format fix
rfaria107 8659019
format fix
rfaria107 77fc3ef
storybook import fix
rfaria107 db04faa
merge fixes
rfaria107 3314292
format fixes (again)
rfaria107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| "use client"; | ||
|
|
||
| import React, { ReactNode } from "react"; | ||
| import Link from "next/link"; | ||
|
|
||
| interface IButtonProps { | ||
rfaria107 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| children?: ReactNode; | ||
| className?: string; | ||
| icon?: ReactNode; | ||
| iconPosition?: "left" | "right"; | ||
| href?: string; | ||
| onClick?: () => void; | ||
| type?: "button" | "submit" | "reset"; | ||
| ariaLabel?: string; | ||
| disabled?: boolean; | ||
| } | ||
|
|
||
| const Button = ({ | ||
| children, | ||
| className = "", | ||
| icon, | ||
| iconPosition = "left", | ||
| href, | ||
| onClick, | ||
| type = "button", | ||
| ariaLabel, | ||
| disabled = false, | ||
| }: IButtonProps) => { | ||
| const baseStyle = "inline-flex items-center justify-center font-medium"; | ||
| const isIconOnly = icon && !children; | ||
| const disabledStyle = disabled ? "pointer-events-none opacity-50" : ""; | ||
|
|
||
| const finalClassName = [baseStyle, className, disabledStyle] | ||
| .filter(Boolean) | ||
| .join(" "); | ||
|
|
||
| const content = isIconOnly ? ( | ||
| <span className="flex items-center justify-center">{icon}</span> | ||
| ) : ( | ||
| <> | ||
| {icon && iconPosition === "left" && ( | ||
| <span className="mr-2 flex">{icon}</span> | ||
| )} | ||
|
|
||
| {children && <span>{children}</span>} | ||
|
|
||
| {icon && iconPosition === "right" && ( | ||
| <span className="ml-2 flex">{icon}</span> | ||
| )} | ||
| </> | ||
| ); | ||
|
|
||
| if (href) { | ||
| const external = | ||
| href.startsWith("http") || | ||
| href.startsWith("mailto:") || | ||
| href.startsWith("tel:"); | ||
|
|
||
| if (disabled) { | ||
| return ( | ||
| <span | ||
| className={finalClassName} | ||
| aria-label={ariaLabel} | ||
| aria-disabled="true" | ||
| > | ||
| {content} | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Link | ||
| href={href} | ||
| className={finalClassName} | ||
| aria-label={ariaLabel} | ||
| {...(external ? { target: "_blank", rel: "noopener noreferrer" } : {})} | ||
| > | ||
| {content} | ||
| </Link> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <button | ||
| type={type} | ||
| onClick={disabled ? undefined : onClick} | ||
| className={finalClassName} | ||
| aria-label={ariaLabel} | ||
| disabled={disabled} | ||
| > | ||
| {content} | ||
| </button> | ||
| ); | ||
| }; | ||
|
|
||
| export default Button; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import React from "react"; | ||
| import type { Meta, StoryObj } from "@storybook/nextjs-vite"; | ||
| import { MdKey, MdDownload } from "react-icons/md"; | ||
| import Button from "@/components/button"; | ||
|
|
||
| type T = typeof Button; | ||
|
|
||
| const meta: Meta<T> = { | ||
| title: "Components/Button", | ||
| component: Button, | ||
| tags: ["autodocs"], | ||
| argTypes: { | ||
| iconPosition: { control: "radio", options: ["left", "right"] }, | ||
| onClick: { action: "clicked" }, | ||
| href: { control: "text" }, | ||
| disabled: { control: "boolean" }, | ||
| ariaLabel: { control: "text" }, | ||
| icon: { control: false }, | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; | ||
|
|
||
| export const TextAndIcon: StoryObj<T> = { | ||
| args: { | ||
| children: "Entrar", | ||
| onClick: () => alert("Entrar"), | ||
| icon: <MdDownload />, | ||
| iconPosition: "left", | ||
| className: | ||
| "border-black border-0 bg-gray-100 px-4 py-3 text-black rounded-full transition duration-200 ease-in-out hover:scale-105 active:scale-95", | ||
| }, | ||
| }; | ||
|
|
||
| export const IconOnly: StoryObj<T> = { | ||
| args: { | ||
| icon: <MdDownload />, | ||
| iconPosition: "right", | ||
| ariaLabel: "Transferir", | ||
| onClick: () => console.log("Transferir"), | ||
| className: "text-orange-500 border-0", | ||
| }, | ||
| }; | ||
|
|
||
| export const TextOnly: StoryObj<T> = { | ||
| args: { | ||
| children: "Editar", | ||
| className: "text-orange-400", | ||
| }, | ||
| }; | ||
|
|
||
| export const Link: StoryObj<T> = { | ||
| args: { | ||
| href: "https://github.com/cesium/astra/issues/2", | ||
| children: "Issue", | ||
| icon: <MdKey />, | ||
| iconPosition: "left", | ||
| className: "border-orange-500 text-orange-500", | ||
| }, | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.