-
Notifications
You must be signed in to change notification settings - Fork 74
Added limits to documentation #3535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/224/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-224/output/_site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for Moduie -> Module and I aslo just thoguht about the limit on execution, cfengine requires the policy files its reading to not be writeable by anyone but the owner (this is only enforced at the mode level afaik, you can bypass it with acls).
|
|
||
| - When strings get excessively long, everything you do with them takes a long time. | ||
| To test this and give some kind of idea: parsing and storing a ~3MB string in a variable took 25 seconds on the author's laptop. | ||
| - If you want to include these variables in reporting data, they will be truncated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try this? If I remember correctly they will be skipped (i.e., not reported at all).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, please try it when you have a chance. (IMO it is a bug if they are skipped).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, it gets truncated, not skipped
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
@cf-bottom Please build this in Jenkins. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/239/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-239/output/_site/ |
No description provided.