Open
Conversation
niqjohnson
approved these changes
Apr 3, 2026
Member
niqjohnson
left a comment
niqjohnson
left a comment
There was a problem hiding this comment.
Header looks identical locally everywhere I checked it. "Remove when Capital Framework is updated to 3.x.x"—what a time capsule!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a fix added way back in #1920 for apps that were since merged into cfgov and no longer exist as external apps with a duplicate header.
Much of the changes you see here are the consequence of removing one level of unnecessary nesting. The consequential change is the removal of
position: initial;.Removals
position: initialTODO.Changes
How to test this PR
yarn buildand the site header should be visually unchanged.