Skip to content

Fix Cypress tests#9044

Open
niqjohnson wants to merge 3 commits intomainfrom
cypress-fixes
Open

Fix Cypress tests#9044
niqjohnson wants to merge 3 commits intomainfrom
cypress-fixes

Conversation

@niqjohnson
Copy link
Copy Markdown
Member

Fix a handful of Cypress tests that were either failing or broken.


Removals

  • cypress/skip-test, which hasn't been maintained since 2023 and no longer works; the one test suite we used it in can be switched to using Cypress.expose() instead

Changes

  • Skip Before You Claim tests (I'm not removing the test files altogether right now because we want to remove all retirement app-related stuff in one fell swoop in the near future)
  • Make a couple of assertions in the prepaid agreement tests case insensitive; the institution we were using to test with now appears in ALL CAPS (which presumably could happen to any institution, so we may as well make the test more flexible instead of choosing another institution)

How to test this PR

  1. yarn cy and make sure all Cypress tests pass (or are correctly skipped)

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

prepaidAgreementsSearch.selectIssuer('Regions Bank');
prepaidAgreementsSearch.applyFilters();
prepaidAgreementsSearch.filters().should('contain', 'Regions');
prepaidAgreementsSearch.filters().contains('Regions', { matchCase: false });
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm contains isn't an assertion https://docs.cypress.io/api/commands/contains … don't you need something like .should('have.length.of.at.most', 1) chained onto this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants