Skip to content

fix table stories and documentation#551

Merged
flacoman91 merged 5 commits intomainfrom
rad-table-update
Apr 15, 2026
Merged

fix table stories and documentation#551
flacoman91 merged 5 commits intomainfrom
rad-table-update

Conversation

@flacoman91
Copy link
Copy Markdown
Collaborator

adding fixes to respond to #548 (comment)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-15 20:03 UTC

@natalia-fitzgerald
Copy link
Copy Markdown
Collaborator

@flacoman91
I took another look at the CFPB Design System documentation page for the Table component and they include right and left-aligned columns there. Can we add the left-aligned one?

Because the DS doesn't have the naming sorted out, let's use the following naming as a stop gap.

  • Right-aligned
  • Left-aligned

For the table, can we match the wording that's used in the DS?

Right-aligned

  • Column 1 | Column 2 | Right-aligned column

Left-aligned

  • Column 1 | Column 2 | Column 3
Screenshot 2026-04-15 at 12 50 09 PM

@natalia-fitzgerald
Copy link
Copy Markdown
Collaborator

@flacoman91
Actually now that we've discussed, I see that right-aligned is a property and left-aligned is the default. So we don't need to add a "Left-aligned" table story.

But, can you still update the column labels for the right-aligned story to use the DS wording?

Right-aligned

  • Column 1 | Column 2 | Right-aligned column

@flacoman91
Copy link
Copy Markdown
Collaborator Author

@flacoman91 Actually now that we've discussed, I see that right-aligned is a property and left-aligned is the default. So we don't need to add a "Left-aligned" table story.

But, can you still update the column labels for the right-aligned story to use the DS wording?

Right-aligned

  • Column 1 | Column 2 | Right-aligned column

This appears done?

https://cfpb.github.io/design-system-react/pr-previews/pr-551/?path=/docs/components-verified-tables--overview

@flacoman91 flacoman91 enabled auto-merge (squash) April 15, 2026 19:26
Copy link
Copy Markdown
Collaborator

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flacoman91 - Looks great. Thank you!

@flacoman91 flacoman91 merged commit ee4f8ce into main Apr 15, 2026
3 checks passed
@flacoman91 flacoman91 deleted the rad-table-update branch April 15, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants