Skip to content

Conversation

@billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Oct 8, 2025

We're taking Kenneth's good work, making it work for more domains, and trying to get it into master so it doesn't have to get deployed separately.

Changes

  • redirects to the correct keycloak instance for a given hostname (see the logic diagrams on the enterprise wiki for Keycloak Redirect Logic as of October 8th 2025)

  • changes checkLoginIframe to false due to CORS issues now related to trying to access an iframe from another domain...
    Screenshot 2025-10-08 at 2 04 48 PM

    ... and probably future problems with it as cookies get more locked down based on some of my digging through keycloak docs and issues. Take a look at issue 23872 on the keycloak repo (avoiding a direct link to the issue so we're not linked into it) for more info on browser incompatibilities.

    There are some downsides to not having it, particularly if someone logs off in another tab then it might not auto-detect the log out. Having said that, Kenneth's PR that implements it has been on hmda beta side for almost a year without complaints. I still made an issue to follow up and investigate re-enabling it or ameliorating any issues, if we feel like we need to down the line.

Testing

  1. Does it work on all the environments?

Local

5181-works-on-local

Dev

5181-works-on-hmdadev

Dev Beta

5181-works-on-dev-beta

Prod Beta

5181-works-on-prod-beta

Prod

(will wait till release)

Alto environments

(will need to wait to see on those)

Notes

@billhimmelsbach billhimmelsbach marked this pull request as ready for review October 8, 2025 21:25
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaas it enters main

@billhimmelsbach billhimmelsbach merged commit d2134f7 into master Oct 9, 2025
1 check passed
@billhimmelsbach billhimmelsbach deleted the 5181-fix-keycloak-redirections-for-aws branch October 9, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants