Skip to content

Base quad meshing#5

Open
colbyj427 wants to merge 69 commits intomasterfrom
base_quad_meshing
Open

Base quad meshing#5
colbyj427 wants to merge 69 commits intomasterfrom
base_quad_meshing

Conversation

@colbyj427
Copy link
Collaborator

No description provided.

Copy link
Owner

@cgoates cgoates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @colbyj427, thank you, this looks great! A few thoughts here:

  • Sadly, in the end, we don't actually use the connections between the quad mesh and the tet mesh, because we already have some tooling available for this on the C++ side, and it simplified the API to do it on the C++ side. I'm thinking if we remove the python code that does that, we will no longer need the half-edge data structure in python, and it might vastly reduce the amount of code we're adding here. Once we've got that simplified down, let's talk about where to fit these files in the directory structure. In general we want to keep as little code as we can while still retaining the desired functionality. It's okay to keep the deleted code in an earlier commit so we can come back and get it if needed later.
  • We want to avoid committing output files. The only obj/vtu/3dm/txt/mtl files we should commit to the repository should be those needed to run tests or examples, and those used for tests should go into the test/data/ folder.
  • Will you please add a test in the test/ folder that does something similar to the test_sweep_param.py new function that you added, but without all the old stuff I had in that file? You can see the general pattern for adding a python test to the list that runs using the ctest command in test/CMakeLists.txt at the bottom. Please check that the test fails if the code fails.

@cgoates cgoates self-assigned this Aug 11, 2025
Colby Johnson added 27 commits August 14, 2025 14:33
@cgoates
Copy link
Owner

cgoates commented Aug 15, 2025

@colbyj427 This all looks great. The only question I have is, where is the ScaleUntrim repo being installed on the runners for the python test you added? I don't see you running the buildScaleUntrim function anywhere, and so I'm wondering how it can be actually running the quad meshing in your test. It seems like perhaps ScaleUntrim not existing isn't causing the test to fail, unless I'm missing something. Other than that, I think this is ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants