Conversation
- Uncomment @oko-wallet/oko-sdk-sol import and types - Add oko_sol state to SDKState interface - Implement initOkoSol() function with proper error handling - Add initOkoSol call in useInitOko hook - Add oko_sol to isInitialized check Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add solanaAddress state and fetch logic in useAddresses hook - Add "solana" chain type to AddressRowProps - Refactor AddressRow to use chainConfig for label/prefix mapping - Add Solana row with SolanaIcon in AddressWidget Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Uncomment SolanaOffchainSignWidget implementation - Uncomment SolanaOnchainSignWidget with Legacy/V0 transaction support - Add isSolLazyInitialized to isLazyInitialized check in PreviewPanel - Import and render Solana sign widgets in PreviewPanel Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
|
@eldenpark Ready for review |
eldenpark
reviewed
Jan 21, 2026
apps/demo_web/src/hooks/wallet.ts
Outdated
| promises.push( | ||
| (async () => { | ||
| try { | ||
| // lazyInit에서 이미 connected=true일 수 있음 |
eldenpark
reviewed
Jan 21, 2026
apps/demo_web/src/hooks/wallet.ts
Outdated
| } catch (err) { | ||
| console.error("Failed to get Solana address:", err); | ||
| } | ||
| })(), |
Collaborator
There was a problem hiding this comment.
Why immediately invoked fn expression?
Contributor
There was a problem hiding this comment.
Why immediately invoked fn expression?
Probably because solana requires connect() before accessing publicKey. Refactored to Promise chaining for consistency. cc. @chemonoworld
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
1. Sol SDK Initialization (
sdk.ts,use_oko.ts)@oko-wallet/oko-sdk-solimport and typesoko_solstate to SDKState interfaceinitOkoSol()functioninitOkoSolcall inuseInitOkohook2. Address Widget (
wallet.ts,address_row.tsx,address_widget.tsx)solanaAddressstate and fetch logic inuseAddresseshookchainConfigrefactoringSolanaIcon3. Solana Sign Widgets (
preview_panel.tsx,solana_*_sign_widget.tsx)SolanaOffchainSignWidget(Ed25519 message signing)SolanaOnchainSignWidget(Legacy/V0 transaction signing)isSolLazyInitializedcheck and widget renderingTest plan
🤖 Generated with Claude Code