Fix name Undefined bug #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

es02 wants to merge 1 commit into chamalabey:master from es02:fix_undefinedUser

es02 commented Dec 14, 2019 •

edited

Loading

Expected Behavior

The script should output "Hello Joe Bloggs"

Actual Behavior

The script outputs "Hello undefined"

Steps to Reproduce the Problem

Git clone express-sample
Run npm/yarn install
Start node server with "node main.js"
test url in browser at http://localhost:3000/

Proposed Changes

moves response sending into getUserName lambda function so response var is available to sending call
changes to async/await to ensure name is picked up before returning data to client
changes function-level const to let and adds semi-colons for code-standards compliance

Specifications

Version: master
Platform: Reproduced under Chromium/Chrome and Firefox (Manjaro x64 kernel 5.4.2-1)


          Fix name Undefined bug

38ea953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet